Skip to content

Block Toolbar Regression - Toolbar obstructs selected blocks. #41575

@Addison-Stavlo

Description

@Addison-Stavlo

When a block is near the top of the canvas and selected, the block toolbar obstructs the block.

We previously resolved this in #29464 by moving the toolbar beneath the selected block IF there is no room in the editor canvas to position it above the block without selected block obstruction.

Some recent change has caused a regression in this behavior, trying to place the toolbar above the block regardless of available space. This causes the toolbar to float over the selected block, obstructing the user from interacting with that block or its children.

BEFORE REGRESSION:
Screen Shot 2022-06-07 at 8 29 41 AM

AFTER REGRESSION (current trunk branch):
Screen Shot 2022-06-07 at 8 31 55 AM

Either we need to:

  • A: Re-add this conditional bottom-positioning behavior AND follow up to resolve the 1 edge case related to calculating the position when popover children are involved (i.e. navigation block submenus as reported here - 40382, 36335, 36977)
  • B: add a background buffer space at the top of the editor canvas / above the template equal to the height needed for the block toolbar. (or do this until we can resolve the edge cases around the solution A)
  • C: conditionally enable the "top toolbar" setting when a block at this position is selected. (or do this until we can resolve edge cases around solution A)
  • D: other ideas?

The current state is extremely limiting and will not be acceptable to be in place for any extended period of time. Users are reporting inability to edit certain blocks near the top of the canvas, such as the main navigation block in their header.

image

cc @talldan @jasmussen @youknowriad @getdave @mtias

Metadata

Metadata

Assignees

Labels

[Priority] HighUsed to indicate top priority items that need quick attention[Type] BugAn existing feature does not function as intended[Type] RegressionRelated to a regression in the latest release

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions