-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Use title in default theme.json to override "Default" label in Site Editor Style Variations #40491
Copy link
Copy link
Open
Labels
Developer ExperienceIdeas about improving block and theme developer experienceIdeas about improving block and theme developer experienceGlobal StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Feature] Theme Style VariationsRelated to style variations provided by block themesRelated to style variations provided by block themes[Feature] ThemesQuestions or issues with incorporating or styling blocks in a theme.Questions or issues with incorporating or styling blocks in a theme.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
Metadata
Metadata
Assignees
Labels
Developer ExperienceIdeas about improving block and theme developer experienceIdeas about improving block and theme developer experienceGlobal StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Feature] Theme Style VariationsRelated to style variations provided by block themesRelated to style variations provided by block themes[Feature] ThemesQuestions or issues with incorporating or styling blocks in a theme.Questions or issues with incorporating or styling blocks in a theme.[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What problem does this address?
Currently, only Style Variations support the
titleattribute not the defaulttheme.json.In the Global Styles panel in the Site Editor
Defaultis hard-coded for naming the default.What is your proposed solution?
It would be nice to prescribe a name other than
Default.Lightthat pairs nicely with a Style Variation namedDark.Whimsical Brand.By supporting
titlein the top-leveltheme.jsonspecification and using it to populate the UI, all those potential outcomes could be addressed.Happy to open a PR to address.