-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Post Comments Form: Implementation Notes #24221
Copy link
Copy link
Closed
Labels
Needs DesignNeeds design efforts.Needs design efforts.[Block] Comments FormAffects the Comments Form BlockAffects the Comments Form Block[Feature] BlocksOverall functionality of blocksOverall functionality of blocks[Feature] Site EditorRelated to the overarching Site Editor (formerly "full site editing")Related to the overarching Site Editor (formerly "full site editing")
Metadata
Metadata
Assignees
Labels
Needs DesignNeeds design efforts.Needs design efforts.[Block] Comments FormAffects the Comments Form BlockAffects the Comments Form Block[Feature] BlocksOverall functionality of blocksOverall functionality of blocks[Feature] Site EditorRelated to the overarching Site Editor (formerly "full site editing")Related to the overarching Site Editor (formerly "full site editing")
Type
Fields
Give feedbackNo fields configured for issues without a type.
The Post Comments Form block is currently implemented to be rendered by
comment_form()on the frontend (which can be fairly complex, containing several different labels, messages, and the form itself in different versions for logged in and out users.In the editor, it is just a placeholder.
We need to match what is editable in the editor with the output produced by the frontend, by replicating the logic of the
comment_form()function (see also #22724 for a breakdown of other possible functions affecting the comment form).All its parameters and the comment form filters (
comment_form_default_fields,comment_form_field_{$name}) should be taken into consideration.Props to @ockham for #24101, which inspired this issue.