-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Opt-in usage tracking notice improvements #2215
Description
Looking a bit into the recently added usage tracking notice, noticed a few things:
There are two "dismiss" buttons:
this is because of the combined effect of the component and the WordPress makeNoticesDismissible() (which runs on document ready). Since this notice appears on page load, makeNoticesDismissible() adds its own dismiss button.
Reducing the strings to translate is always a good thing. See Dismiss this notice vs. Dismiss this notice. (period at the end).
The order of the elements in the notice could be improved. Currently, the Yes and No button are placed before the text. Screen reader users will hear, in this order:
Yes
No
Can Gutenberg collect data ...
Dismiss this notice
(Dismiss this notice.)
Also from a logical perspective, I'd say available answers should go after the question.
All text is wrapped in <div>s. It would be nice to use slightly more semantic elements for text. The WordPress notices use paragraphs.
The italic text uses a font-size: 90%; which translates to a computed value of 11.7px. This is definitely too small. I'd also propose to use values that translate to a computed value without rounding.
Minor: the rendering is different across browsers. I'd propose no action on this, just something to be aware of:
Chrome:
Firefox:
this ie because bold text is rendered differently.


