-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Components: Improve Toolbar #18619
Copy link
Copy link
Closed
Labels
[Feature] UI ComponentsImpacts or related to the UI component systemImpacts or related to the UI component system[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Metadata
Metadata
Assignees
Labels
[Feature] UI ComponentsImpacts or related to the UI component systemImpacts or related to the UI component system[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Type
Fields
Give feedbackNo fields configured for issues without a type.
I'm creating this issue to place together the steps necessary to improve both the API and the accessibility of the
Toolbarcomponent in@wordpress/components. This work started on #17875, but, since the PR has become too complex, we've chosen to break it into more parts:[Components: Add accessible Toolbar #18534] Introduce an
__experimentalaccessibleToolbarcomponent in@wordpress/components[Components: Improve ToolbarButton #18931] Improve
ToolbarButtonso that it serves more use cases than just being anIconButton.[Components: Refactor SlotFill #19242] Refactor
SlotFillso we won't need to force fills to re-render whenfillPropschange.[Convert core toolbar buttons into ToolbarButton #20008] Convert the fixed toolbar buttons (block switcher, more tools etc.) to
ToolbarButton.[Implement roving tabindex on the header toolbar #22354] Convert header toolbar.
[Implement roving tabindex on the Image block #22696] [Implement roving tabindex on grouped blocks toolbars #23216] [Implement roving tabindex on the table block toolbar #23252] [Implement roving tabindex on the Custom HTML block toolbar #23277] [Implement roving tabindex on the Embed block toolbar #23278] [Implement roving tabindex on the Navigation block toolbar #23281] Convert all core block toolbars.
This will fix Toolbar elements are tabbable #15331 and Toolbar: consider to use a roving tabindex and standardize navigation #3383.
[Make accessible toolbar stable and deprecate old usage #23316] If it proves to be useful and works out, deprecate the old usage and remove the
__experimentalprefix. Otherwise, revert it altogether, which would break the code for people using__experimentalAccessibilityLabelexplicitly, but custom blocks would seamlessly rollback to the old usage.