Skip to content

FocalPointPicker renders unlabelled input fields #13894

@afercia

Description

@afercia

See #10925 (comment)

The FocalPointPicker component renders two input fields that are completely unlabelled:

screenshot 2019-02-15 at 14 47 04

The visible text is just plain text. There's no associated <label> element or aria-label attribute to give these two controls a proper label. I'm going to create an issue.

As this is not the first case unlabelled UI controls are merged in Gutenberg, I'd greatly appreciate some discussion to find a way to avoid this kind of oversights. Better code reviews or automated testing may help. Thank you.

Metadata

Metadata

Labels

[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] BugAn existing feature does not function as intended

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions