-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Editor: Eliminate or refactor store notices constants #11202
Copy link
Copy link
Closed
Labels
FrameworkIssues related to broader framework topics, especially as it relates to javascriptIssues related to broader framework topics, especially as it relates to javascriptNeeds DevReady for, and needs developer effortsReady for, and needs developer efforts[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality
Metadata
Metadata
Assignees
Labels
FrameworkIssues related to broader framework topics, especially as it relates to javascriptIssues related to broader framework topics, especially as it relates to javascriptNeeds DevReady for, and needs developer effortsReady for, and needs developer efforts[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality
Type
Fields
Give feedbackNo fields configured for issues without a type.
Previously: #9617 (comment)
We now inconsistently use constants for referencing notices by ID in the editor module. The primary need for them is in dismissal upon the start of a new save (e.g. autosave notice, previous save success/error notice).
We should consider one of:
In #9617, it was chosen to not use the constant to avoid a dependency between the component and the store, though this is loosely held.