Switch to @wordpress/eslint-plugin/recommended standards#72
Merged
kadamwhite merged 9 commits intoWordPress:masterfrom Mar 19, 2019
kadamwhite:update-coding-standards
Merged
Switch to @wordpress/eslint-plugin/recommended standards#72kadamwhite merged 9 commits intoWordPress:masterfrom kadamwhite:update-coding-standards
kadamwhite merged 9 commits intoWordPress:masterfrom
kadamwhite:update-coding-standards
Conversation
Merged
ntwb
approved these changes
Mar 13, 2019
Member
ntwb
left a comment
There was a problem hiding this comment.
Awesome, thanks a bunch @kadamwhite , this has been on my todo list for the longest time
Member
|
This was blazing fast, it all looks great 👍 |
gziolo
approved these changes
Mar 13, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from the old coding standards to the latest
@wordpress/eslint-plugin/recommendedoptions, for better parity with Gutenberg code.Note: This PR includes #71. For an isolated diff of the coding-standards-related changes, see kadamwhite/grunt-patch-wordpress#1.