Show plugin icons#249
Conversation
…or various scenarios
… for fallback logic
|
@claude can you review this? AND I let you fix if those are easy fixes |
|
Claude finished @AllTerrainDeveloper's task in 3m 24s —— View job PR Review: Show plugin icons
Review summaryOverall: High-quality PR. The local-icon-probe logic is clean, the fallback chain extension is well-tested, and docs are updated alongside the code. Three issues were found and fixed in commit Bugs fixed1. Broken anchor link in The - …since-0xy))…
+ …since-086))…2. Stale fallback-chain description in This PR adds GIF variants to the JS fallback chain ( - The JS card walks a candidate chain (SVG → 256 PNG → 128 PNG) on `<img>` error
+ The JS card walks a candidate chain (SVG → 256 PNG → 256 GIF → 128 PNG → 128 GIF) on `<img>` errorNotes (no action needed)
|
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
…n chain descriptions - Replace placeholder `since-0xy` anchor with `since-086` in hooks-reference.md table row - Update fallback chain descriptions from `SVG → 256 PNG → 128 PNG` to `SVG → 256 PNG → 256 GIF → 128 PNG → 128 GIF` in both hooks-reference.md and the rest-fields.php docblock — matching the actual icon-fallback.ts implementation Co-authored-by: Daniel López Sánchez (prismiwi2015) <AllTerrainDeveloper@users.noreply.github.com>
Support for missing images in the plugins list (gifs, and fallback to local files)