fix(preview): pass id to windowManager.open from Open in editor button#219
Merged
Conversation
The "Open in editor" button in the folder preview pane called wm.open() without an `id`, which throws since the WindowManager contract requires a non-empty config.id. Derive the id from the shortcut's postType so reopens focus the existing editor window instead of stacking duplicates, mirroring openEditor() in src/my-wordpress/index.ts.
Contributor
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: windowManager.open(): config.id must be a non-empty stringand did nothing.renderPostPreview()insrc/desktop-files/preview.tscalledwm.open()without anid.WindowManager.open()requiresconfig.idto be a non-empty string (src/window-manager/index.ts:384) and throws otherwise.entityIdfromfile.postType(the same shape the Explore details button just above already uses) and passid: \${entityId}-edit-${postId}`. This matchesopenEditor()insrc/my-wordpress/index.ts`, so reopening the same shortcut focuses the existing editor window instead of stacking duplicates.Test plan
npm run buildcleannpm run lintclean./node_modules/.bin/tsc --noEmitcleannpm run test:js(1214/1214 passing)