Sanitize DOS (Windows) new line style on readme.txt#681
Merged
matiasbenedetto merged 2 commits intotrunkfrom Jul 3, 2024
Merged
Sanitize DOS (Windows) new line style on readme.txt#681matiasbenedetto merged 2 commits intotrunkfrom
matiasbenedetto merged 2 commits intotrunkfrom
Conversation
mikachan
approved these changes
Jul 3, 2024
Member
mikachan
left a comment
There was a problem hiding this comment.
Thanks for addressing this! Code looks good to me and it's testing well. I think we can bring this in 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces DOS new line style on readme.txt
Why?
This type of character causes problems on WordPress.org theme directory.
Reference from a theme review:
Fixes #680
How?
The "\r\n" new line characters are replaced by the unix style new line character "\n" when creating or updating a readme.txt text.