This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Read csv file instead of an array of domains#97
Merged
michalczaplinski merged 3 commits intoperf-and-stress-testingfrom Oct 28, 2022
Merged
Read csv file instead of an array of domains#97michalczaplinski merged 3 commits intoperf-and-stress-testingfrom
csv file instead of an array of domains#97michalczaplinski merged 3 commits intoperf-and-stress-testingfrom
Conversation
michalczaplinski
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another thing we could do, especially if we are planning to test different files (which can be pretty big), is read a
csvfile instead of creating an array. In the long term, I feel is gonna be better.In order to do that, I just added a
fs.createReadStream('./benchmark/sites.csv'), parsed the csv and created an array of domains with the first column.