This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Use page.evaluate instead of page.addScriptTag#95
Merged
michalczaplinski merged 1 commit intoperf-and-stress-testingfrom Oct 28, 2022
Merged
Use page.evaluate instead of page.addScriptTag#95michalczaplinski merged 1 commit intoperf-and-stress-testingfrom
page.evaluate instead of page.addScriptTag#95michalczaplinski merged 1 commit intoperf-and-stress-testingfrom
Conversation
Collaborator
|
Great improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing the workflow with different sites and in some of them (TechCrunch and The Hill for example), there was a Content Security Policy error:
Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'none'I think that this can be solved using
evaluateinstead ofaddScripTag.