Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

🎨 Admin for client side navigations#88

Merged
luisherranz merged 1 commit intomain-wp-directives-pluginfrom
admin-for-client-side-transitions
Oct 20, 2022
Merged

🎨 Admin for client side navigations#88
luisherranz merged 1 commit intomain-wp-directives-pluginfrom
admin-for-client-side-transitions

Conversation

@luisherranz
Copy link
Copy Markdown
Member

@luisherranz luisherranz commented Oct 19, 2022

It's just an admin page to opt-in to the client-side navigations.

I did it on top of #86, so we need to merge that one first.

Screenshot 2022-10-19 at 20 07 20

This is meant for testing only. It doesn't mean we intend to add an option to WordPress.

If you had the plugin installed before, please deactivate and activate the plugin again so it creates the default settings.

@luisherranz luisherranz self-assigned this Oct 19, 2022
@luisherranz luisherranz changed the base branch from main-custom-elements-hydration to main-wp-directives-plugin October 19, 2022 18:08
@luisherranz luisherranz changed the base branch from main-wp-directives-plugin to opt-in-for-client-side-transitions October 19, 2022 18:08
Copy link
Copy Markdown
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂 Btw, if in the future we decide to start only with the filter and not the Admin page, I've realized that we can ask to use plugins like Code Snippets for those that can't modify the code.

Base automatically changed from opt-in-for-client-side-transitions to main-wp-directives-plugin October 20, 2022 07:26
@luisherranz
Copy link
Copy Markdown
Member Author

Indeed 🙂

Thanks, Mario!

@luisherranz luisherranz merged commit 56a72f7 into main-wp-directives-plugin Oct 20, 2022
@luisherranz luisherranz deleted the admin-for-client-side-transitions branch October 20, 2022 07:27
@luisherranz luisherranz changed the title 🎨 Admin for client side transitions 🎨 Admin for client side navigations Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants