This repository was archived by the owner on Jul 28, 2023. It is now read-only.
🎨 Add prefetch to all links and prevent scroll in pagination#87
Merged
SantosGuillamot merged 3 commits intomain-wp-directives-pluginfrom Oct 20, 2022
Merged
🎨 Add prefetch to all links and prevent scroll in pagination#87SantosGuillamot merged 3 commits intomain-wp-directives-pluginfrom
prefetch to all links and prevent scroll in pagination#87SantosGuillamot merged 3 commits intomain-wp-directives-pluginfrom
Conversation
23 tasks
luisherranz
approved these changes
Oct 20, 2022
wp-directives.php
Outdated
| } | ||
|
|
||
| $link = parse_url($w->get_attribute('href')); | ||
| $classes = $w->get_attribute('class'); |
Member
There was a problem hiding this comment.
It's a minimal optimization, but you can move this getter inside the if.
Contributor
Author
There was a problem hiding this comment.
Totally right! I've just changed it 🙂
prefetch to all links and prevent scroll in paginationprefetch to all links and prevent scroll in pagination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the
prefetchproperty to all the links andscroll=falseto all the pagination links. While doing so we realized that the HTML of the parent blocks contain the children, so we were parsing the HTML multiple times. For that, we change the filters to only trigger for the Query Loop and the Template Parts until we figure out a better solution.