This repository was archived by the owner on Jul 28, 2023. It is now read-only.
🎨 Remove comments and preserve scripts#84
Merged
luisherranz merged 1 commit intomain-wp-directives-pluginfrom Oct 18, 2022
Merged
🎨 Remove comments and preserve scripts#84luisherranz merged 1 commit intomain-wp-directives-pluginfrom
luisherranz merged 1 commit intomain-wp-directives-pluginfrom
Conversation
23 tasks
SantosGuillamot
approved these changes
Oct 18, 2022
Contributor
SantosGuillamot
left a comment
There was a problem hiding this comment.
LGTM! 🙂 Although I'm not 100% sure how to test it.
Member
Author
|
We'll keep testing it, don't worry 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't remember why we removed the script's children in the first place. We should investigate that, so let's preserve them again and see when they fail.
I've also added logic to remove the comments because Preact doesn't support them during the hydration. We may need to add them back after the hydration if sites rely on them, but for now, I'd keep them removed.