This repository was archived by the owner on Jul 28, 2023. It is now read-only.
⚛️ Add directives to handle providesContext and usesContext#68
Merged
DAreRodz merged 5 commits intomain-full-vdom-hydrationfrom Sep 15, 2022
Merged
⚛️ Add directives to handle providesContext and usesContext#68DAreRodz merged 5 commits intomain-full-vdom-hydrationfrom
providesContext and usesContext#68DAreRodz merged 5 commits intomain-full-vdom-hydrationfrom
Conversation
DAreRodz
commented
Sep 15, 2022
Comment on lines
+58
to
+59
| // Create vNode. Note that all `wpBlock` props should exist now to make directives work. | ||
| const vNode = h(type, props, children); |
Collaborator
Author
There was a problem hiding this comment.
Here I've assumed that options.vnode would run every time h() is used. Maybe I'm wrong here. 🤔
luisherranz
approved these changes
Sep 15, 2022
Member
luisherranz
left a comment
There was a problem hiding this comment.
At first glance, it looks great to me. I'm glad the current implementation of the directives is flexible enough to inject atomic functionality into the vdom. However, I was hoping we could delegate more to the wrapper component and less to the vdom internals.
But we can keep playing with this API in other PRs.
Collaborator
Author
I left three things inside
Thanks for your review @luisherranz. I'm merging this PR. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
I've refactored
toVdomsignificantly and added support for directives like in WordPress/gutenberg#44034. There are still some code I haven't moved to directives, like sourced attributes generation and inner blocks location (not sure if it is possible).Also, I created three directives:
typeand renders the block component (if it exists).providesContextand renders a wrapper around block children.usesContext, that injects acontextproperty to a block component using a HOC.Directives are placed in
src/directives.