This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Merged
Conversation
This was referenced Jul 26, 2022
michalczaplinski
approved these changes
Jul 26, 2022
Collaborator
michalczaplinski
left a comment
There was a problem hiding this comment.
I'm not crazy about those wp- prefixes but for now it's not a problem if we want to change them in the future. We should just be mindful so that this "internal" name does not get stuck like FSE (Full Site Editing) did 🙂 .
Collaborator
Reading #37, it seems to me that the whole purpose of this PR is to avoid sticking with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
frontend.jsfiles andFrontendcomponentes withview.jsandView"frontend": trueattribute prop with"public": truegutenberg-withwp-block-