This repository was archived by the owner on Jul 28, 2023. It is now read-only.
wp-bind improvements and negation in runtime#213
Merged
SantosGuillamot merged 3 commits intomain-wp-directives-pluginfrom Apr 14, 2023
Merged
Conversation
SantosGuillamot
approved these changes
Apr 14, 2023
Contributor
SantosGuillamot
left a comment
There was a problem hiding this comment.
Looks great to me! 🙂
This was referenced Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
data-wp-bind.checked="!state.checked".data-wp-bindto modify attributes on hydration (Preact doesn't modify them when usinghydrate).data-wp-bind, including one that uses"!state.checked".Why
Because
!is easy enough to add, and it's very useful when combined withdata-wp-showordata-wp-bind.hidden(if/else).How
!.data-wp-bind, add auseEffectand change the DOM manually to reflect the vDOM (similar todata-wp-class).Notes
data-wp-bind.checked, I stumbled upon this weird thing: When you change thecheckedattribute of a node with React (reproduced here) or Preact (reproduced here), the browser doesn't update thecheckedattribute of the component. Everything seems to work becauseelement.checkedis correct and Dan says this is correct way of doing it, but at first it's pretty confusing 😅