This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Handle missing class attribute inside wp-class#149
Merged
DAreRodz merged 2 commits intomain-wp-directives-pluginfrom Feb 20, 2023
Merged
Handle missing class attribute inside wp-class#149DAreRodz merged 2 commits intomain-wp-directives-pluginfrom
wp-class#149DAreRodz merged 2 commits intomain-wp-directives-pluginfrom
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug while hydrating
wp-classdirectives. It happens when theclassattribute is not defined―something that occurs when no class is server-side rendered. E.g., the following HTMLcurrently throws this error:
Also, when the button is clicked, the application crashes.
Why
Directives should take care of those attributes they affect.
In this case, developers shouldn't be forced to write an empty class to make the
wp-classdirective work as expected.How
Simply using an empty string when
element.props.classis undefined.