This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Make wp-context inheritable and extensible#139
Merged
DAreRodz merged 10 commits intomain-wp-directives-pluginfrom Jan 26, 2023
Merged
Make wp-context inheritable and extensible#139DAreRodz merged 10 commits intomain-wp-directives-pluginfrom
wp-context inheritable and extensible#139DAreRodz merged 10 commits intomain-wp-directives-pluginfrom
Conversation
6 tasks
23 tasks
luisherranz
approved these changes
Jan 26, 2023
Member
luisherranz
left a comment
There was a problem hiding this comment.
Beautiful. I think it's ready to merge 🙂
Oh, and thanks for starting to use TypeScript, by the way.
Comment on lines
+18
to
+23
| <button | ||
| data-testid="parent prop1" | ||
| name="prop1" | ||
| value="modifiedFromParent" | ||
| wp-on:click="actions.updateContext" | ||
| > |
Member
There was a problem hiding this comment.
Using attributes as function arguments is smart. You are always coming up with interesting patterns, David 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
(Re) implement the
wp-contextdirective so nested contexts can inherit properties from the parent context. Inherited properties can also be shadowed if redeclared in the child context.Why
At this moment, a child context replaces the parent context entirely, but contexts should be inheritable and extensible to cover most use cases.
How
Implementing a
mergeDeepSignalsfunction that copies signals from the parent context only if they're not already defined in the child context. That would allow, for example, changes in inherited properties from the child context to be reflected in the parent one, except in the case those properties are shadowed.