This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Switch to the deepsignal package#128
Merged
luisherranz merged 1 commit intomain-wp-directives-pluginfrom Jan 11, 2023
Merged
Conversation
398b043 to
7635e65
Compare
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Just switch from the internal implementation of
deepSignalto the deepsignal package.Why
Because the package is feature complete, has versioning, tests, etc. We'll move it to the WordPress org in the future if WordPress ends up using it.
How
Just remove the
deepSignalcode and addingdeepsignalas a dependency.