This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Ignore ref attr while generating virtual nodes#122
Merged
SantosGuillamot merged 1 commit intomain-wp-directives-pluginfrom Dec 16, 2022
Merged
Ignore ref attr while generating virtual nodes#122SantosGuillamot merged 1 commit intomain-wp-directives-pluginfrom
ref attr while generating virtual nodes#122SantosGuillamot merged 1 commit intomain-wp-directives-pluginfrom
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @DAreRodz suggested here, I'm ignoring the
refattribute while generating virtual nodes. This seems to solve the hydration error that sites withrefattributes were returning.I am planning to add tests for this and other use cases in other PR.