This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Treat nodeType 7 like comments#121
Merged
SantosGuillamot merged 1 commit intomain-wp-directives-pluginfrom Dec 16, 2022
Merged
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #117 , there are some sites using
xpacketinside SVG nodes, which returns a hydration error. As David suggests here, and following MDN docs, I am filling this PR to treat them like comments and removing them.I am planning to add tests for this and other use cases in other PR.