Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

WP Directives Plugin: Require Gutenberg plugin to avoid a fatal error#119

Merged
cbravobernal merged 4 commits intomain-wp-directives-pluginfrom
update/require-gutenberg
Dec 16, 2022
Merged

WP Directives Plugin: Require Gutenberg plugin to avoid a fatal error#119
cbravobernal merged 4 commits intomain-wp-directives-pluginfrom
update/require-gutenberg

Conversation

@cbravobernal
Copy link
Copy Markdown
Collaborator

Why

Right now, in the weird case that somebody installs the directives plugin without Gutenberg, they will get a fatal error, as we are using WP_HTML_Tag_Processor, which is declared in that plugin.
Screenshot 2022-12-14 at 16 33 04

How

With GPT-3, of course
Screenshot 2022-12-14 at 16 39 57

Testing

Screen.Recording.2022-12-14.at.16.31.44.mov

@cbravobernal cbravobernal changed the title Update/require gutenberg WP Directives Plugin: Require Gutenberg plugin to avoid a fatal error Dec 14, 2022
Copy link
Copy Markdown
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A minor detail, it seems there are some different formatting in the functions.

Btw, not sure what is the status of the Plugin Dependencies Feature Project, but in the future we should use that I guess.

@cbravobernal
Copy link
Copy Markdown
Collaborator Author

Btw, not sure what is the status of the Plugin Dependencies Feature Project, but in the future we should use that I guess.

It seems that it is a plugin. You need to have it installed, so I guess having not won't prevent the fatal error.

it seems there are some different formatting in the functions.

I installed and applied WordPress PHP format so it's the same as standards. Also applied to the PHP files we had.

@SantosGuillamot
Copy link
Copy Markdown
Contributor

It seems that it is a plugin. You need to have it installed, so I guess having not won't prevent the fatal error.

Yes, I think right now it is a plugin. But if I am not mistaken, they are planning to include in core. That's why I said that in the future, we could do this using that feature. It was just an informative comment, nothing to change 🙂

I installed and applied WordPress PHP format so it's the same as standards. Also applied to the PHP files we had.

Oh, I thought we already had that, sorry 😄 Thanks a lot for adding it!

@cbravobernal cbravobernal merged commit 08efce6 into main-wp-directives-plugin Dec 16, 2022
@cbravobernal cbravobernal deleted the update/require-gutenberg branch December 16, 2022 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants