This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Handle CDATA nodes#115
Merged
SantosGuillamot merged 2 commits intomain-wp-directives-pluginfrom Dec 2, 2022
Merged
Conversation
DAreRodz
approved these changes
Dec 2, 2022
Collaborator
DAreRodz
left a comment
There was a problem hiding this comment.
Thanks, @SantosGuillamot! I guess we'll have to sync the stress-testing branch (#91) with these changes.
Can you also leave a note in the Tracking issue: WordPress Directives Plugin 🎨 #80? 😊
23 tasks
Contributor
Author
Yes, I was planning to do so once this one is merged. I'll try to do it now.
Just did it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm creating this Pull Request with the solution proposed at #109
I also reverted #107. I made that one trying to solve the problem with
attributesbeingundefinedcaused by theCDATAnodes. However, now that this is handled properly, it makes sense to revert that change in case we encounter another similar use case with undefined attributes. We should identify them and not skip them.