Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Fix hydration error root fragment is not defined in the stress testing#113

Merged
SantosGuillamot merged 1 commit intoperf-and-stress-testingfrom
fix/hydration-error-root-fragment
Dec 1, 2022
Merged

Fix hydration error root fragment is not defined in the stress testing#113
SantosGuillamot merged 1 commit intoperf-and-stress-testingfrom
fix/hydration-error-root-fragment

Conversation

@SantosGuillamot
Copy link
Copy Markdown
Contributor

Now that we are registering the hydrationError, I was running the script on some sites, and there wasn't any success registered. It seems all of them are returning the following hydrationError: rootFragment is not defined.

After triaging it with @c4rl0sbr4v0 and @luisherranz , it seems the issue comes from defining rootFragment as a global. Defining it as a local variable seems to solve the problem.

@SantosGuillamot SantosGuillamot merged commit fc61c22 into perf-and-stress-testing Dec 1, 2022
@SantosGuillamot SantosGuillamot deleted the fix/hydration-error-root-fragment branch December 1, 2022 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant