fix: rename unforwarded MaskCanvas to InnerMaskCanvas to avoid duplicate declarations.#713
Merged
Conversation
…plicate declarations.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes
This PR renames the internal
MaskCanvascomponent function toInnerMaskCanvasand sets an explicitdisplayNamefor the forwardedconst MaskCanvasthat wraps it.Why?
After updating our dependencies in #712 , Eslint warns about
The explicit
displayNamehelps debuggers and React Dev Tools not get cofused by the forwardedRef noise now that the components aren't identically named.How?
See diff.
Use of AI Tools
I asked GitHub Copilot Chat to check the repo is there was a previous naming convention used for this sorts of forwardRef wrappers. When the results came back negative, I asked it to check more broadly whether
Unforwarded<ComponentName>orInner<ComponentName>was the more common ecosystem pattern.Naming things is 🤷
Testing Instructions
Screenshots or screencast
Changelog Entry