Adds Abilities Explorer #63
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #63 +/- ##
=============================================
+ Coverage 47.97% 50.35% +2.38%
- Complexity 243 366 +123
=============================================
Files 22 26 +4
Lines 1430 1952 +522
=============================================
+ Hits 686 983 +297
- Misses 744 969 +225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mindctrl
left a comment
There was a problem hiding this comment.
I'm digging this so far. I left a question or two and some feedback, mostly about coding standards.
| * | ||
| * @since 0.1.0 | ||
| */ | ||
| class Admin_Page { |
There was a problem hiding this comment.
Similar to other classes, I think we could type arguments and returns.
There was a problem hiding this comment.
Did a first pass in 86d7754, got everything but the array shapes, since I want to investigate those more directly.
jonathanbossenger
left a comment
There was a problem hiding this comment.
I think this will be a great feature for the plugin. Left a bunch of suggestions, happy to discuss any of them further.
| * @since 0.1.0 | ||
| */ | ||
| private function render_detail_view() { | ||
| $ability_slug = isset( $_GET['ability'] ) ? sanitize_text_field( wp_unslash( $_GET['ability'] ) ) : ''; |
There was a problem hiding this comment.
This code is duplicated again at line 316. Is it worth calling this once higher up the chain, and then passing the $ability_slug to the relevant render_ method?
includes/Features/Abilities_Explorer/assets/js/abilities-explorer.js
Outdated
Show resolved
Hide resolved
includes/Features/Abilities_Explorer/assets/js/abilities-explorer.js
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
PS: our CI/CD assumes trunk-based development so CI/CD isnt running on Here's the PHPStan output from this branch atm. The missing array shapes are likely noise, but the type conflicts are likely pointing to real bugs that need addressing (h/t @jeffpaul ) ------ ------------------------------------------------------------------------------------------
Line includes/Features/Abilities_Explorer/Abilities_Explorer.php
------ ------------------------------------------------------------------------------------------
:30 Constant WordPress\AI\Features\Abilities_Explorer\Abilities_Explorer::VERSION is unused.
🪪 classConstant.unused
💡 See: https://phpstan.org/developing-extensions/always-used-class-constants
------ ------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line includes/Features/Abilities_Explorer/Ability_Handler.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------
:33 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::get_all_abilities() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:51 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::get_ability() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:73 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::format_abilities() has parameter $abilities with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:73 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::format_abilities() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:95 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::format_single_ability() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:130 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::detect_provider() has parameter $meta with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:165 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::invoke_ability() has parameter $input with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:165 PHPDoc tag @return with type array is incompatible with native type string.
🪪 return.phpDocType
:167 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::invoke_ability() should return string but returns array<string, string|false>.
🪪 return.type
:176 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::invoke_ability() should return string but returns array<string, string|false>.
🪪 return.type
:192 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::invoke_ability() should return string but returns array<string, mixed>.
🪪 return.type
:200 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::invoke_ability() should return string but returns array<string, mixed>.
🪪 return.type
:215 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::validate_input() has parameter $input with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:215 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::validate_input() has parameter $schema with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:215 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::validate_input() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:290 Method WordPress\AI\Features\Abilities_Explorer\Ability_Handler::get_statistics() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line includes/Features/Abilities_Explorer/Ability_Table.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
:52 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::get_columns() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:69 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::get_sortable_columns() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:82 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::prepare_items() has no return type specified.
🪪 missingType.return
:139 Parameter #1 $args of method WP_List_Table::set_pagination_args() expects array{total_items?: int, total_pages?: int, per_page?: int}, array{total_items: int<0, max>, per_page: 20, total_pages: float}
given.
🪪 argument.type
💡 Offset 'total_pages' (int) does not accept type float.
:158 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_default() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:170 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_cb() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:185 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_name() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:211 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_slug() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:226 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_provider() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:245 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::column_actions() has parameter $item with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:280 Method WordPress\AI\Features\Abilities_Explorer\Ability_Table::extra_tablenav() has no return type specified.
🪪 missingType.return
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------
Line includes/Features/Abilities_Explorer/Admin_Page.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------
:100 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::render_statistics() has no return type specified.
🪪 missingType.return
:133 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::render_list_view() has no return type specified.
🪪 missingType.return
:153 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::render_detail_view() has no return type specified.
🪪 missingType.return
:209 Parameter #1 $text of function esc_html expects string, string|false given.
🪪 argument.type
:217 Parameter #1 $text of function esc_html expects string, string|false given.
🪪 argument.type
:224 Parameter #1 $text of function esc_html expects string, string|false given.
🪪 argument.type
:235 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::render_test_runner() has no return type specified.
🪪 missingType.return
:303 Parameter #1 $text of function esc_textarea expects string, string|false given.
🪪 argument.type
:328 Parameter #1 $text of function esc_html expects string, string|false given.
🪪 argument.type
:347 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::generate_example_input() has parameter $schema with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:347 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::generate_example_input() return type has no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:369 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::get_example_value() has parameter $prop_schema with no value type specified in iterable type array.
🪪 missingType.iterableValue
💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
:402 Method WordPress\AI\Features\Abilities_Explorer\Admin_Page::ajax_invoke_ability() has no return type specified.
🪪 missingType.return
:455 Offset 'success' does not exist on string.
🪪 offsetAccess.notFound
:459 Offset 'data' does not exist on string.
🪪 offsetAccess.notFound
:465 Offset 'error' on string in isset() does not exist.
🪪 isset.offset
:466 Offset 'trace' on string in isset() does not exist.
🪪 isset.offset
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------
[ERROR] Found 45 errors |
So our test workflow has always been set to run when a pull request is opened, not depending on the base branch (see https://github.com/WordPress/ai/blob/develop/.github/workflows/test.yml#L9-L13). This is working on other PRs (see example run https://github.com/WordPress/ai/actions/runs/20016361492/job/57394802798) so not sure why this didn't work on the latest commit to this PR. I'm assuming (hoping) if the latest changes from |
Oooh thanks for correcting me. Saw Interestingly, the workflows were running up until the latest commit, but the only changes in the diff are PHP-related 🤔 
|
|
@karmatosed @justlevine @jonathanbossenger perhaps a docs page for this like done in https://github.com/WordPress/ai/pull/155/changes#diff-f70665388390657902e73741dea03efcdadc4bd0ceb4432959f8903ae015c042? |
|
e40898b merged develop -> this branch but did not relocate the files from |
…ack and ensure those are loaded using our Asset_Loader
… those during a release
|
I've made a decent amount of changes here and in my opinion, this is ready to go. For anyone following along, here's the most recent updates:
I wouldn't expect most of these changes to have an impact other than changing things around with the asset files (particularly since those had previously been removed). Probably worth someone else testing things again to ensure it all still works as expected (cc @jeffpaul @karmatosed) |
What?
This is an initial very raw version PR to add an Abilities Explorer to the plugin. Responds to #62.
For now this adds a new menu item where you can see the abilities. You can also view or test them
Requires 6.9 beta to work.
Why?
Responds to the proposal in #62 and focuses on making them visible whilst providing a learning opportunity.
How?
This is a simpler implementation, adding a menu item and keeping it totally seperate as proposed for features.
Testing Instructions
Once using branch and installed you should be able to access it from Abilities menu item.
Screenshots or screencast
Note: as this is a work in progress going to keep as a draft until both decided on as direction and had some robust code review. This is being created from an experiment so there likely are code dragons - let’s slay them!