Skip to content

Code Quality: Remove deprecated __nextHasNoMarginBottom prop#609

Merged
dkotter merged 1 commit into
WordPress:developfrom
yogeshbhutkar:code-quality/remove-deprecated-no-margin-prop
May 26, 2026
Merged

Code Quality: Remove deprecated __nextHasNoMarginBottom prop#609
dkotter merged 1 commit into
WordPress:developfrom
yogeshbhutkar:code-quality/remove-deprecated-no-margin-prop

Conversation

@yogeshbhutkar

@yogeshbhutkar yogeshbhutkar commented May 22, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

What, Why, and How?

Removes the usage of the deprecated __nextHasNoMarginBottom prop as it's the default behavior since WordPress 7.0. The soft deprecation was introduced in WP 6.7 and scheduled to be removed in WP 7.0.

Related:
WordPress/gutenberg#73848
WordPress/gutenberg#75139

Use of AI Tools

None

Testing Instructions

  1. Tests should pass
  2. No visual diff

Changelog Entry

Removed - deprecated __nextHasNoMarginBottom prop

Open WordPress Playground Preview

@codecov

codecov Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.18%. Comparing base (3624c91) to head (acb212d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop     #609   +/-   ##
==========================================
  Coverage      73.18%   73.18%           
  Complexity      1731     1731           
==========================================
  Files             85       85           
  Lines           7473     7473           
==========================================
  Hits            5469     5469           
  Misses          2004     2004
Flag Coverage Δ
unit 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review May 22, 2026 10:27
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jeffpaul jeffpaul requested a review from dkotter May 26, 2026 15:04
@jeffpaul jeffpaul added this to the 1.1.0 milestone May 26, 2026
@jeffpaul jeffpaul moved this from Triage to Needs review in WordPress AI Roadmap May 26, 2026
@dkotter dkotter merged commit a21b69d into WordPress:develop May 26, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from Needs review to Done in WordPress AI Roadmap May 26, 2026
@yogeshbhutkar yogeshbhutkar deleted the code-quality/remove-deprecated-no-margin-prop branch May 27, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@yogeshbhutkar yogeshbhutkar

Labels

None yet

Projects

WordPress AI Roadmap
Status: Done

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@yogeshbhutkar @dkotter @jeffpaul