The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Could also bury this option a bit more by placing it within the vertical 3 dot menu where the "Add note" button/link is. No real strong opinion on this, happy to land this as-is and iterate from community feedback.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.48%. Comparing base (3b059d9) to head (71f765d).
⚠️ Report is 11 commits behind head on develop.

@@            Coverage Diff             @@
##             develop     #267   +/-   ##
==========================================
  Coverage      57.48%   57.48%           
  Complexity       563      563           
==========================================
  Files             35       35           
  Lines           2907     2907           
==========================================
  Hits            1671     1671           
  Misses          1236     1236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Could also bury this option a bit more by placing it within the vertical 3 dot menu where the "Add note" button/link is. No real strong opinion on this, happy to land this as-is and iterate from community feedback.

Yeah, wasn't sure exactly where to put this. It's nice at the top-level because it's easy to find but I never loved it there (easy to be confused on what it actually is). I've moved it to the nested menu now

Any chance of dropping this right after the Add note menu option? Perhaps updating to "Generate review note" to match the (oddly) sentence case here? Perhaps also replacing the icon with a keyboard shortcut of CAPSLOCK COMMAND M (to be simmilar to "Add note" one of OPTION COMMAND M)?

Any chance of dropping this right after the Add note menu option?

As far as I can find (and had Claude and Cursor look as well) there's only two available slots here for us to use. One is what we're using now which drops things into the section before the section that has the Delete button (with no controls on where it shows in that section). Or there's a unstable API that adds it as the very first item in that menu. That may be better positioning though has the risk of using the unstable API.

Perhaps updating to "Generate review note" to match the (oddly) sentence case here?

I can update that to match

Perhaps also replacing the icon with a keyboard shortcut of CAPSLOCK COMMAND M (to be simmilar to "Add note" one of OPTION COMMAND M)?

I'm assuming you'd not just want to update the icon to be the shortcut but then also have that keyboard shortcut trigger this functionality? If so, the problem here is the loading state only shows on the button. So if someone uses the keyboard shortcut when the block is selected but they don't have that menu open, there isn't a loading state that shows (so no real way for them to know something is happening). I can look into ways to add a loading animation to the entire block if we think the keyboard shortcut would be useful.

Worth noting two other things:

1. Looks like the keyboard shortcut for Notes is part of 7.0 (or when using the Gutenberg plugin). I don't see that on 6.9
2. Looks like capslock is not a valid shortcut so we'd need to use something else (command, shift, option and control are all options)

Bah, I'd say just merge as-is and we can iterate once 7.0 is out and we get some feedback on the feature. No need to chase down these last couple of bits.