Abilities Explorer: Add i18n to labels.#247
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
=============================================
+ Coverage 55.75% 55.87% +0.11%
- Complexity 507 509 +2
=============================================
Files 32 32
Lines 2606 2613 +7
=============================================
+ Hits 1453 1460 +7
Misses 1153 1153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Explorer page continues to work as expected, so as long as @dkotter is fine with the technical changes here then I'm fine to approve/merge |
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
What?
Makes ability provider labels translatable by implementing a label mapping system. Also updated the badge dimensions to be in line with the badge component.
Why?
Provider labels for abilities (Plugin, Theme, Core) were hardcoded and not translatable. Since we use the keys for filtering and other logic, we need to separate the display labels from the internal keys. That's why the mapping.
How?
Added a label mapping function that translates provider keys to translatable labels.
Testing Instructions