Abilities Explorer: Fix "copy" button placement.#245
Abilities Explorer: Fix "copy" button placement.#245jeffpaul merged 2 commits intoWordPress:developfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #245 +/- ##
==========================================
Coverage 56.69% 56.69%
Complexity 505 505
==========================================
Files 32 32
Lines 2568 2568
==========================================
Hits 1456 1456
Misses 1112 1112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What?
Fixes layout issues with the "Copy" button in ability code blocks and improves the copy feedback UX.
Why?
The "Copy" button was breaking out of the code block and appearing as a separate column instead of overlaying the
<pre>element. Additionally, the "Copied to clipboard" text caused an abrupt button size change and felt redundant.How?
Testing Instructions
Screenshots or screencast
Before
abilities-copy-before.mp4
With the fix
abilities-fix-copy-styles.mp4