Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.02%. Comparing base (6a6eafa) to head (a26bf4e).
⚠️ Report is 28 commits behind head on develop.

@@              Coverage Diff              @@
##             develop     #235      +/-   ##
=============================================
+ Coverage      55.98%   56.02%   +0.04%     
- Complexity       509      511       +2     
=============================================
  Files             32       32              
  Lines           2608     2622      +14     
=============================================
+ Hits            1460     1469       +9     
- Misses          1148     1153       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @prabinjha, @kurtrank.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: prabinjha, kurtrank.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

In addition to generating an image from a prompt, you can also send that image back with another prompt attached to generate image edits, allowing you to iterate on an image until you like it (NOTE: this isn't working yet as this requires upstream changes to the OpenAI and Google AI provider packages).

If that's not ready in time for us to merge/release on this PR, then let's update the context in #236 to include that perhaps?

Testing feedback...

1. Need to update the styling in the Image block sidebar's Media panel after clicking Add image as the Generate Image button should appear more like the links for Open Media Library and Upload options perhaps using the create icon

2. Instead of Keep in the Generate Image modal perhaps utilize Use Image?

3. Instead of Edit in the Generate Image modal perhaps utilize Refine Image?
4. Instead of Start Over perhaps we use Edit Prompt and keep the previously entered prompt in the textarea?
5. On this screen, let's add another button (sigh, I know, :ALOT:) for Generate Another Image in case they didn't like the image generated, don't want to change the prompt, and don't want to refine the generated image
6. Within the Edit/Refine Image flow, perhaps instead of Generate we use Refine for the primary button?

7. Within the Edit/Refine Image flow, perhaps instead of Back we use Cancel Refinement for the secondary button?
8. When adding a Gallery and going into the Generate Image flow and getting to the Keep action, it should end up in the Edit Gallery modal, but instead inserts the image into the post in an Image block
9. Do we want to add this flow as a second level menu option within the Media top level menu item in the WP admin? If so, then perhaps we also add a button in the header of the Library screen next to the Add Media File button?

Need to update the styling in the Image block sidebar's Media panel after clicking Add image as the Generate Image button should appear more like the links for Open Media Library and Upload options perhaps using the create icon

Similar to #252, this particular section only shows if you're using the Gutenberg plugin (or on WP 7.0-beta1). That said, I realized the editor.MediaUpload filter we use to insert our Generate Image button into the default block state also runs when rendering the block toolbar options (Replace button for image, Add for gallery):

Seems this is the same thing that is rendering in that new sidebar section so I've updated our code to handle this so this should look correct there now. I've also removed the custom toolbar button I was adding as there's no need for two buttons there.

Instead of Keep in the Generate Image modal perhaps utilize Use Image?

Updated

Instead of Edit in the Generate Image modal perhaps utilize Refine Image?

Updated

Instead of Start Over perhaps we use Edit Prompt and keep the previously entered prompt in the textarea

Updated

On this screen, let's add another button (sigh, I know, :ALOT:) for Generate Another Image in case they didn't like the image generated, don't want to change the prompt, and don't want to refine the generated image

Added this

Within the Edit/Refine Image flow, perhaps instead of Generate we use Refine for the primary button

Updated

Within the Edit/Refine Image flow, perhaps instead of Back we use Cancel Refinement for the secondary button

Updated

When adding a Gallery and going into the Generate Image flow and getting to the Keep action, it should end up in the Edit Gallery modal, but instead inserts the image into the post in an Image block

I was trying to match the same flow you get if you use the Upload button in the gallery block (or drag an image into the block). In that case, it renders the inner image block immediately (same as what we're doing here).

I do like the user experience of pushing them to that media modal so I've attempted to simulate that now (noting this all uses the media library modal code that isn't super easy to extend so may still have some rough edges).

Do we want to add this flow as a second level menu option within the Media top level menu item in the WP admin? If so, then perhaps we also add a button in the header of the Library screen next to the Add Media File button

I think the answer is yes though I'd suggest that's a separate PR as all the code here is scoped to the block editor and so we'll need a different approach to support anything outside of that

If that's not ready in time for us to merge/release on this PR, then let's update the context in #236 to include that perhaps?

Looking into this more, seems changes will be needed both in the PHP AI Client and in each provider implementation, so I don't think this will be done prior to this PR being ready. I'll likely remove all of the edit/refine image work from this PR but I'll wait until we can discuss that.

I think the answer is yes though I'd suggest that's a separate PR as all the code here is scoped to the block editor and so we'll need a different approach to support anything outside of that

I created #254 for that follow-up work.

Looking into this more, seems changes will be needed both in the PHP AI Client and in each provider implementation, so I don't think this will be done prior to this PR being ready. I'll likely remove all of the edit/refine image work from this PR but I'll wait until we can discuss that.

@dkotter feel free to remove that and then merge, everything else here looks great!

All the image editing/refinement code has been removed now. Was hoping to be able to leave that and get that working upstream but don't want to block this PR any longer.

For future reference (when we hopefully can add this back) here's the commit that removed all of that: 68c6450

re-running Plugin Check and WP latest test checks...