-
Notifications
You must be signed in to change notification settings - Fork 50
ci: build zip file for GitHub release #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #24 +/- ##
========================================
Coverage ? 92.48%
Complexity ? 99
========================================
Files ? 7
Lines ? 519
Branches ? 0
========================================
Hits ? 480
Misses ? 39
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm not entirely sure whether we plan to distribute the plugin in the WordPress registry. @Jameswlepage, do you know how this repo is going to be consumed in the long run outside of using npm and composer packages? |
gziolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still might be useful to offer a downladable zip file with the plugin for testing so I'm approving the changes.
@gziolo just to confirm - nothing in this PR is connected to submitting this as a .org plugin, and with a 6.9 merge goal, my assumption too is that we're not planning to submit.
Exactly this. Goal is to attach the dist builds to the GitHub releases to order to composer/wpcli/manual users and testers to require/download/install the dist version without the bundled tests/CI/config files. In MCP Adapter, I'm recommending installing the dist version (now it users the source) in via wp-env.json, while if we stick with the initial bash approach, it would probably use the dist zip via a wpcli call. |
|
Cool, I resolved merge conflicts and enabled auto-merge 🚀 |
What
This PR adds a GitHub workflow to create a distribution build of the plugin, and attach it to the GitHub release.
Why
Provides closure on distribution methods:
wp plugin install https://github.com/WordPress/abilities-api/releases/latest/download/abilities-api.zip{ "repositories": [ { "type": "vcs", "url": "https://github.com/WordPress/abilities-api.git" } ], }composer require wordpress/abilities-api --saveTo Test
wordpress/abilities-apiwith my fork:justlevine/abilities-api