dev: use $request->get_params() in REST controllers
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22 +/- ##
========================================
Coverage ? 90.66%
Complexity ? 99
========================================
Files ? 7
Lines ? 557
Branches ? 0
========================================
Hits ? 505
Misses ? 52
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gziolo
approved these changes
Aug 18, 2025
Member
gziolo
left a comment
There was a problem hiding this comment.
Nice, thank you for a follow up 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates our WP_REST_* controller classes to use
$request->get_params()or$request->get_param( $param_name ), instead of usingArrayAccessto get the $request parameters directly.Why
This opts the params into the full
WP_Rest*lifecycle, so therest_request_parameter_orderfilter etc are applied consistently.