Skip to content

ci: fix lint trigger on test GH workflow #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gziolo merged 1 commit into from
Aug 14, 2025
Merged

ci: fix lint trigger on test GH workflow #17

gziolo merged 1 commit into from
Aug 14, 2025

Conversation

@justlevine
Copy link
Contributor

@justlevine justlevine commented Aug 14, 2025

What

This fixes a bug in the GH workflow where the test CI was not being triggered by activity on trunk

Why

Part of #13

How

The push call was unintentionally limited to changes in the workflow itself.

@justlevine justlevine mentioned this pull request Aug 14, 2025
Closed
9 tasks
gziolo
gziolo approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@gziolo gziolo merged commit 7cf8bb6 into WordPress:trunk Aug 14, 2025
20 of 21 checks passed
@codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (trunk@dd94fce). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff            @@
##             trunk      #17   +/-   ##
========================================
  Coverage         ?   90.64%           
  Complexity       ?      102           
========================================
  Files            ?        7           
  Lines            ?      556           
  Branches         ?        0           
========================================
  Hits             ?      504           
  Misses           ?       52           
  Partials         ?        0
Flag Coverage Δ
unit 90.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gziolo gziolo added [Type] Bug Something isn't working [Tool] Issues related to development tooling, such as linting, testing, or CI labels Aug 14, 2025
@gziolo
Copy link
Member

gziolo commented Aug 14, 2025

Works!

Screenshot 2025-08-14 at 15 59 43

@justlevine justlevine deleted the ci/test-trunk branch August 14, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

@justlevine justlevine

Labels

[Tool] Issues related to development tooling, such as linting, testing, or CI [Type] Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justlevine @gziolo