Adding language metabox to the meeting post type#1139
Merged
adamwoodnz merged 5 commits intotrunkfrom Dec 5, 2022
Merged
Conversation
Fixes linting error
Collaborator
Author
|
I used the existing metabox files to add this new one - I hope that's the right place for it, but I'm happy to move things around if there's a better location. |
Collaborator
Author
|
New 'Meeting Language' metabox shows up in the sidebar:
The meta field registration and default value were already added in a previous PR, so this PR is simply rendering the metabox and saving the field when the post is updated. |
adamwoodnz
reviewed
Dec 5, 2022
Co-authored-by: Adam Wood <adam.wood@automattic.com>
adamwoodnz
reviewed
Dec 5, 2022
wp-content/plugins/wporg-learn/views/metabox-meeting-language.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wood <adam.wood@automattic.com>
adamwoodnz
reviewed
Dec 5, 2022
wp-content/plugins/wporg-learn/views/metabox-meeting-language.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wood <adam.wood@automattic.com>
adamwoodnz
requested changes
Dec 5, 2022
Contributor
adamwoodnz
left a comment
There was a problem hiding this comment.
Works for me, just one a11y fix needed
Collaborator
Author
|
I have added all the changes you suggested, including the a11y fix - that was a good catch! This is ready to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the language metabox to the meeting post type - this completed the work done in #1009 and is necessary for the filtering in #1008 to be possible.