Migrate Tutorials video_language -> language meta field#1067
Merged
adamwoodnz merged 6 commits intotrunkfrom Nov 23, 2022
Merged
Migrate Tutorials video_language -> language meta field#1067adamwoodnz merged 6 commits intotrunkfrom
video_language -> language meta field#1067adamwoodnz merged 6 commits intotrunkfrom
Conversation
4f8d918 to
0b5f6a3
Compare
3a66015 to
bcfa5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1038
All post meta data for the
video_languagefield has been copied to the newlanguagefield so we can now removevideo_language.Areas affected
video_languageremoved from admin tablevideo_languagetolanguagevideo_languageon edit screen removed (and saving of field)video_languagetolanguagevideo_languagetolanguagevideo_languagetolanguagevideo_languagetolanguagevideo_languagefield is no longer registeredHow to test
Before switching to this branch (ie. on trunk), ensure that some tutorials in your local instance have both

video_languageandlanguagemeta set (either set a few manually, or trash existing/destroy env and re-import from prod). These should have columns for 'Language' and 'Video Language' displayed in the admin table with matching values. When editing the Language field is the topmost document setting, and the video language is in the Workshop Details meta box:Switch to this branch and check all of the above affected areas
For 7, try changing locale when viewing the tutorials page on the frontend, and observe any tutorials with
languagematching your locale being displayed first