Skip to content

Migrate Tutorials video_language -> language meta field#1067

Merged
adamwoodnz merged 6 commits intotrunkfrom
update/1038-tutorials-migrate-to-language
Nov 23, 2022
Merged

Migrate Tutorials video_language -> language meta field#1067
adamwoodnz merged 6 commits intotrunkfrom
update/1038-tutorials-migrate-to-language

Conversation

@adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Nov 1, 2022

See #1038

All post meta data for the video_language field has been copied to the new language field so we can now remove video_language.

Areas affected

  1. Column displaying video_language removed from admin table
  2. Filter on admin table switched from video_language to language
  3. Metabox field for video_language on edit screen removed (and saving of field)
  4. Frontend filtering switched from video_language to language
  5. Language on frontend single Tutorial details switched from video_language to language
  6. Custom query to prioritize content in the user's locale switched from video_language to language
  7. Tutorial application form schema switched from video_language to language
  8. The video_language field is no longer registered

How to test

  1. Before switching to this branch (ie. on trunk), ensure that some tutorials in your local instance have both video_language and language meta set (either set a few manually, or trash existing/destroy env and re-import from prod). These should have columns for 'Language' and 'Video Language' displayed in the admin table with matching values. When editing the Language field is the topmost document setting, and the video language is in the Workshop Details meta box:
    Screen Shot 2022-11-04 at 1 23 54 PM

  2. Switch to this branch and check all of the above affected areas

  3. For 7, try changing locale when viewing the tutorials page on the frontend, and observe any tutorials with language matching your locale being displayed first

@adamwoodnz adamwoodnz marked this pull request as draft November 1, 2022 03:52
@adamwoodnz adamwoodnz force-pushed the update/1038-tutorials-migrate-to-language branch from 4f8d918 to 0b5f6a3 Compare November 2, 2022 03:24
@adamwoodnz adamwoodnz self-assigned this Nov 2, 2022
@adamwoodnz adamwoodnz marked this pull request as ready for review November 2, 2022 21:56
@adamwoodnz adamwoodnz added [Component] Learn Theme Website development issues related to the Learn theme. [Component] Learn Plugin Website development issues related to the Learn plugin. labels Nov 2, 2022
@adamwoodnz adamwoodnz force-pushed the update/1038-tutorials-migrate-to-language branch from 3a66015 to bcfa5e3 Compare November 23, 2022 02:19
Copy link
Collaborator

@hlashbrooke hlashbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@adamwoodnz adamwoodnz merged commit 032e753 into trunk Nov 23, 2022
@adamwoodnz adamwoodnz deleted the update/1038-tutorials-migrate-to-language branch November 23, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Component] Learn Plugin Website development issues related to the Learn plugin. [Component] Learn Theme Website development issues related to the Learn theme.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Migrate Tutorial video_language meta field to new language meta field

2 participants