Updated keyboard name style for consistency#43
Merged
simon-wh merged 1 commit intoWootingKb:feature/lekker-supportfrom Aug 23, 2021
diogotr7:feature/lekker-support
Merged
Updated keyboard name style for consistency#43simon-wh merged 1 commit intoWootingKb:feature/lekker-supportfrom diogotr7:feature/lekker-support
simon-wh merged 1 commit intoWootingKb:feature/lekker-supportfrom
diogotr7:feature/lekker-support
Conversation
Member
|
Good idea, keep that consistency, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the other two keyboards have names with the first letter uppercase, i updated these for consistency.
This change also happens to make my life easier when updating the RGB.NET device provider:
Currently the keyboard names are hardcoded as "Wooting One" and "Wooting Two", depending on
wooting_usb_meta.device_type. I've changed it so the model from the sdk is used instead to more easily support the lekker and HE boards.This lets Artemis users keep their profiles intact as changing the name of the keyboard would alter its id.