Make properties public in Grid View Page #6514
Closed
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties such as **`pageNo`**, **`sortField`**, and **`sortOrder`** are available in **`MultipleLinkPage`**, but they are not exposed in the new **`AbstractGridViewPage`** implementation. There’s no clear justification for limiting access to these attributes. As a developer, I may need direct access to these properties, for example, to persist user preferences, implement custom pagination or sorting behavior, or synchronize state between the frontend and backend. Therefore, it would be beneficial to make these properties accessible (e.g., through protected or public getters), ensuring greater flexibility and consistency with the previous implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties such as
pageNo,sortField, andsortOrderare available inMultipleLinkPage, but they are not exposed in the newAbstractGridViewPageimplementation. There’s no clear justification for limiting access to these attributes.As a developer, I may need direct access to these properties, for example, to persist user preferences, implement custom pagination or sorting behavior, or synchronize state between the frontend and backend. Therefore, it would be beneficial to make these properties accessible (e.g., through protected or public getters), ensuring greater flexibility and consistency with the previous implementation.