Skip to content

Remove all traces of reflection in ObjectSnapshot#34

Closed
Taluu wants to merge 4 commits intoWisembly:masterfrom
Taluu:no-reflection-snapshot
Closed

Remove all traces of reflection in ObjectSnapshot#34
Taluu wants to merge 4 commits intoWisembly:masterfrom
Taluu:no-reflection-snapshot

Conversation

@Taluu
Copy link
Contributor

@Taluu Taluu commented Dec 25, 2015

Merry christmas @krichprollsch and @lunika, if this works as it should... ❤️

Basically, removing all traces or dependencies towards Reflection for an ObjectSnapshot. Need to create more tests though with actual objects (see https://gist.github.com/Taluu/2ed4d1d71d5c0db291c4#gistcomment-1657274)

  • Remove Reflection stuff
  • Add some tests for private / protected properties

It's a little bit hackish though, even though it is still far more optimized like this.

@Taluu Taluu force-pushed the no-reflection-snapshot branch 4 times, most recently from 30a333f to 1d07a97 Compare December 25, 2015 23:20
@Taluu Taluu force-pushed the no-reflection-snapshot branch from 1d07a97 to ddd1028 Compare December 25, 2015 23:23
@Taluu
Copy link
Contributor Author

Taluu commented Dec 26, 2015

https://blackfire.io/profiles/compare/e3790154-b2fc-4fa8-b7cd-ed99f55fd271/graph Here is a comparision before / after. Basically, it's about 20 to 40% better :}

@Taluu
Copy link
Contributor Author

Taluu commented Dec 27, 2015

Closing, as the target has changed (1.x instead of master)

@Taluu Taluu closed this Dec 27, 2015
@Taluu Taluu mentioned this pull request Dec 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Taluu