Skip to content

chore(build.yml): update Electron version support to include v41#1452

Merged
mceachen merged 1 commit intoWiseLibs:masterfrom
mceachen:electron-41
Mar 11, 2026
Merged

chore(build.yml): update Electron version support to include v41#1452
mceachen merged 1 commit intoWiseLibs:masterfrom
mceachen:electron-41

Conversation

@mceachen
Copy link
Copy Markdown
Member

(we should drop node 23 at some point too)

@mceachen mceachen requested review from a team and JoshuaWise as code owners March 11, 2026 04:28
@m4heshd
Copy link
Copy Markdown
Contributor

m4heshd commented Mar 11, 2026

(we should drop node 23 at some point too)

I feel like we shouldn't be building for non-LTS Node targets at all. Thoughts?

@mceachen
Copy link
Copy Markdown
Member Author

I think we should expect people to download any and all versions currently available from nodejs.org

(I didn't delete v23 because I was chicken pretty sure that the second I do we will have bug reports from HEY WHERE IS OLD AND BROKEN NODE I NEEEEEEED IT didn't want to bump the major version number)

@mceachen mceachen merged commit fca9fff into WiseLibs:master Mar 11, 2026
14 of 30 checks passed
@m4heshd
Copy link
Copy Markdown
Contributor

m4heshd commented Mar 11, 2026

(I didn't delete v23 because I was chicken pretty sure that the second I do we will have bug reports from HEY WHERE IS OLD AND BROKEN NODE I NEEEEEEED IT didn't want to bump the major version number)

Haha. Fair enough. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants