Skip to content

Add missing macOS x64 builds#1419

Merged
JoshuaWise merged 1 commit intoWiseLibs:masterfrom
m4heshd:fix-macos-builds
Nov 15, 2025
Merged

Add missing macOS x64 builds#1419
JoshuaWise merged 1 commit intoWiseLibs:masterfrom
m4heshd:fix-macos-builds

Conversation

@m4heshd
Copy link
Copy Markdown
Contributor

@m4heshd m4heshd commented Nov 15, 2025

This PR reinstates the macOS x64 runner in the build script.

Since the last update to the build script, both of the macOS runners (macos-14 and macos-15) now being used are arm64 runners, which results in duplicate artifacts. Also, the artifacts are now missing macOS x64 builds.

@m4heshd m4heshd requested review from a team and JoshuaWise as code owners November 15, 2025 13:34
@JoshuaWise JoshuaWise merged commit be59741 into WiseLibs:master Nov 15, 2025
22 checks passed
@JoshuaWise
Copy link
Copy Markdown
Member

Apparently that image costs money? https://github.com/WiseLibs/better-sqlite3/actions/runs/19392504797/job/55487984693

@mceachen
Copy link
Copy Markdown
Member

Apparently that image costs money? https://github.com/WiseLibs/better-sqlite3/actions/runs/19392504797/job/55487984693

IT DOES!

Unfortunately, if you want an intel macos image, you now need to use either macos-13, or macos-15-intel

https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@mceachen
Copy link
Copy Markdown
Member

Also -- thanks again for your assistance, @m4heshd , much appreciated as always!

@m4heshd
Copy link
Copy Markdown
Contributor Author

m4heshd commented Nov 15, 2025

Unfortunately, if you want an intel macos image, you now need to use either macos-13, or macos-15-intel

That's wild. I had no idea. Weird that I use macos-15-intel tag on all my personal projects, but somehow I decided to use the macos-15-large tag just for this PR 😄. I'll send the fix right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants