zh-CN language pack update#52
Conversation
There was a problem hiding this comment.
Hello @thiliapr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the Chinese (Simplified, China) language pack (zh-CN) in app/src/main/res/values-zh-rCN/strings.xml. The changes involve reorganizing the string resources into logical sections such as general strings, bottom navigation, snackbar actions, dialog strings, ZIP archive options, TAR archive options, 7z archive options, success toast messages, error toast messages, and notification related strings. It also includes some updated translations and minor textual improvements.
Highlights
- String Reorganization: The string resources have been reorganized into logical sections for better maintainability and readability.
- Translation Updates: Several strings have been updated with improved Chinese translations.
- New Strings: New strings have been added for confirm password, passwords do not match, file already exists, and wrong password.
Changelog
- app/src/main/res/values-zh-rCN/strings.xml
- Added a copyright notice at the beginning of the file.
- Reorganized strings into sections like 'General strings', 'Bottom navigation', 'Snackbar actions', 'Dialog strings', 'ZIP archive options', 'TAR archive options', '7z archive options', 'Success toast messages', 'Error toast messages', and 'Notification channel name'.
- Updated translations for various strings, including 'sort_by', 'split_size_mb', and 'info_tip_description'.
- Added new strings for 'confirm_password', 'passwords_do_not_match', 'wrong_password', and 'file_already_exists'.
- Changed the default value description for split_size_mb from 64KB to 64KiB.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
In realms of code, where strings reside,
A language pack, our focus and pride.
From English tongue to Chinese script,
Translations flow, a linguistic gift.With careful touch and artful hand,
We shape the words across the land.
For every user, near and far,
A seamless experience, like a shining star.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the zh-CN language pack for the application. The changes include adding new translations, reorganizing existing strings, and updating some translations. Overall, the changes seem to improve the localization of the app for Chinese-speaking users.
Summary of Findings
- Inconsistent terminology: The pull request introduces some inconsistencies in terminology. For example, both "归档" and "存档" are used for "archive". It would be better to use a consistent term throughout the app.
- Inaccurate translation: Some translations may not be accurate or idiomatic. For example, "垃圾日志" for "crash log" is not a common term. It would be better to use a more accurate and user-friendly translation.
- Missing context: Some translations lack context, making it difficult to understand their meaning. For example, "命令" for "order" is ambiguous. It would be helpful to provide more context or use a more specific translation.
Merge Readiness
The pull request is not ready to be merged. There are several issues that need to be addressed before merging, including inconsistent terminology, inaccurate translations, and missing context. I am unable to approve this pull request, and users should have others review and approve this code before merging.
| <string name="operation_cancelled">操作取消</string> | ||
| <string name="tar_creation_failed">创建tar文件失败</string> | ||
| <string name="copied_to_clipboard">已复制到剪贴板</string> | ||
| <string name="operation_cancelled">操作被取消</string> |
There was a problem hiding this comment.
"操作被取消" might be a bit too literal. Consider using a more common phrase like "已取消".
<string name="operation_cancelled">已取消</string>
There was a problem hiding this comment.
"已取消操作" may be.better
As you see