Skip to content

Mouse Pan Broken #136

@thejmazz

Description

@thejmazz

Mouse pan broken due to thunk methods not being invoked. I have fix, will make PR soon.

For example, diff on panLeft:

-    const panLeft = () => {
+    const panLeft = (() => {
       const v = new Vector3();

-      return function panLeft(distance, objectMatrix) {
+      return (distance, objectMatrix) => {
         v.setFromMatrixColumn(objectMatrix, 0); // get X column of objectMatrix
         v.multiplyScalar(-distance);

         panOffset.add(v);

       };
-    };
+    })();
Version:
  • r11
  • r10
  • r9
  • r9 (dev)
  • r8
  • r7
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question

Tested on: ###### --- Desktop - [ ] Chrome - [ ] Chrome Canary - [ ] Chrome dev-channel - [ ] Firefox - [ ] Opera - [ ] Microsoft IE - [ ] Microsoft Edge
--- Android
  • Chrome
  • Firefox
  • Opera
--- IOS
  • Chrome
  • Firefox
  • Opera

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions