Skip to content

fix(utils): use strxfrm only if it works#14032

Merged
nijel merged 1 commit intoWeblateOrg:mainfrom
nijel:strxfrm
Feb 27, 2025
Merged

fix(utils): use strxfrm only if it works#14032
nijel merged 1 commit intoWeblateOrg:mainfrom
nijel:strxfrm

Conversation

@nijel
Copy link
Copy Markdown
Member

@nijel nijel commented Feb 27, 2025

fix(utils): use strxfrm only if it works

Fixes #14019

Built on top of #14023

@nijel nijel self-assigned this Feb 27, 2025
@nijel nijel modified the milestones: 5.11, 5.10.2 Feb 27, 2025
@nijel nijel marked this pull request as ready for review February 27, 2025 07:42
@nijel nijel requested a review from AliceVisek as a code owner February 27, 2025 07:42
@nijel nijel removed the request for review from AliceVisek February 27, 2025 07:43
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (6dcabb2) to head (16fe9b7).
Report is 3177 commits behind head on main.

Files with missing lines Patch % Lines
weblate/trans/util.py 70.00% 3 Missing ⚠️
weblate/trans/tests/test_sort.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14032      +/-   ##
==========================================
- Coverage   91.02%   91.02%   -0.01%     
==========================================
  Files         608      608              
  Lines       63618    63625       +7     
  Branches     6582     6582              
==========================================
+ Hits        57907    57912       +5     
- Misses       4019     4021       +2     
  Partials     1692     1692              
Files with missing lines Coverage Δ
weblate/trans/tests/test_sort.py 75.00% <0.00%> (ø)
weblate/trans/util.py 87.84% <70.00%> (-0.67%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nijel nijel merged commit ffcaa90 into WeblateOrg:main Feb 27, 2025
48 of 49 checks passed
@nijel nijel deleted the strxfrm branch February 27, 2025 08:50
Copy link
Copy Markdown

@Jin-Shikai Jin-Shikai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locale aware sorting crashes on macOS 15 with OSError

2 participants