Merged
Conversation
- Replicate master Settings API from better-external-links across all repositories - Add new Settings_Wizard_API class with multi-step wizard framework - Enhance Settings_Form with improved field rendering capabilities - Update Settings_Sanitize with advanced validation methods - Improve Metabox_API with better integration hooks - Remove deprecated phpcs:ignore comments for cleaner code - Optimize script enqueueing and localization handling - Add sidebar.php fallback support for better compatibility - Update encryption methods for API key management Files updated: - class-settings-api.php (main API wrapper) - class-settings-form.php (form generation) - class-settings-sanitize.php (input sanitization) - class-metabox-api.php (metabox handling) - class-settings-wizard-api.php (wizard framework) This brings all repositories in sync with the latest Settings API improvements.
- Fix critical bug where repeater fields were not properly captured - Add ob_start() before HTML output in callback_repeater method - Ensures repeater HTML is properly filtered and processed - Follows same pattern as plugin_settings() and show_form() methods - Prevents direct output bypassing filter mechanism This fixes the issue where ob_get_clean() was returning false/empty, causing repeater HTML to be sent directly to browser instead of being processed through the Settings API filter system.
- Copy latest includes folder from pro version - Remove Freemius premium initialization from class-main.php - Update version to 4.2.4 in better-search.php - Update stable tag in readme.txt - Maintain Pro property declaration for compatibility
Ensures add_settings_error messages from change_settings_on_save are displayed on the settings page for consistent admin notice visibility.
- Replace entire includes folder with pro version - Remove pro/ subfolder from includes - Remove Freemius premium initialization from class-main.php - Regenerate POT file and update PO/MO files
…prefix - Replace parent_base check with screen base check for better accuracy - Prevents duplicate settings notices on WordPress settings pages - Updated in all class-settings-api.php files across repositories
…stency - Remove @fs_premium_only annotations and Update URI from main plugin file - Update plugin name from 'Better Search Pro' to 'Better Search' - Remove includes/pro/ directory - Remove Freemius conditional initialization from class-main.php - Update language files to reference free plugin version and support URLs - Update composer.json and package.json names to remove -pro suffix - Add GitHub issue templates (bug_report.md, feature_request.md) - Fix version inconsistencies between header and constants - Update BETTER_SEARCH_VERSION to 4.2.4 to match pro version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.