[JSC] ReferenceError when multiple modules are simultaneously importing a module containing a top-level await by shvaikalesh · Pull Request #24122 · WebKit/WebKit

shvaikalesh · 2024-02-09T03:26:50Z

`cf39202`

[JSC] ReferenceError when multiple modules are simultaneously importing a module containing a top-level await
https://bugs.webkit.org/show_bug.cgi?id=242740
<rdar://problem/97370038>

Reviewed by NOBODY (OOPS!).

This change completely re-implements module loader to precisely follow the spec steps [1],
resolving multiple issues revolving around importing modules with top-level `await`.

Infinite retry of module fetching & parsing is removed as it's not part of the spec,
nor other browsers behave in the same way.

This patch also rewires the way module loader is hooked into workers / worklets, which became
necessary due to functions like evaluateModule() became always `async`. Along with this,
errors occuring in modules with top-level `await` are now properly reported to the console,
resolving another developers' pain point.

[1]: https://tc39.es/ecma262/#sec-cyclic-module-records

* JSTests/test262/expectations.yaml:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/cors-crossorigin-requests-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-throw-importScripts.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-throw-importScripts.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/crossorigin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-fetch-error.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/error-type-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/error-type-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-4-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-4-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-5-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-6-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-7-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-error/worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-failure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-parse-error-failure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-parse-error-failure-expected.txt:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/builtins/ModuleLoader.js:
(visibility.PrivateRecursive.ensureModuleMapEntry):
(visibility.PrivateRecursive.hostFetchAndLoadImportedModule):
(visibility.PrivateRecursive.hostLoadImportedModule):
(visibility.PrivateRecursive.fetchDescendantsOfAndLink):
(visibility.PrivateRecursive.innerModuleLoading):
(visibility.PrivateRecursive.moduleLinking):
(visibility.PrivateRecursive.innerModuleLinking):
(visibility.PrivateRecursive.moduleEvaluation):
(visibility.PrivateRecursive.innerModuleEvaluation):
(visibility.PrivateRecursive.async executeAsyncModule):
(linkTimeConstant.gatherAvailableAncestors):
(visibility.PrivateRecursive.asyncModuleExecutionFulfilled):
(linkTimeConstant.asyncModuleExecutionRejected):
(visibility.PrivateRecursive.fetchModule):
(visibility.PrivateRecursive.fetchModuleAndEvaluate):
(visibility.PrivateRecursive.evaluateModule):
(visibility.PrivateRecursive.loadModule):
(visibility.PrivateRecursive.loadModuleAndEvaluate):
(visibility.PrivateRecursive.requestImportModule):
(visibility.PrivateRecursive.dependencyKeysIfEvaluated):
(linkTimeConstant.setStateToMax): Deleted.
(linkTimeConstant.newRegistryEntry): Deleted.
(visibility.PrivateRecursive.ensureRegistered): Deleted.
(linkTimeConstant.forceFulfillPromise): Deleted.
(linkTimeConstant.fulfillFetch): Deleted.
(visibility.PrivateRecursive.requestFetch): Deleted.
(linkTimeConstant.cacheSatisfy): Deleted.
(async linkTimeConstant.cacheSatisfyAndReturn): Deleted.
(visibility.PrivateRecursive.requestSatisfy): Deleted.
(visibility.PrivateRecursive.requestSatisfyUtil): Deleted.
(visibility.PrivateRecursive.link): Deleted.
(visibility.PrivateRecursive.async asyncModuleEvaluation): Deleted.
(visibility.PrivateRecursive.provideFetch): Deleted.
(visibility.PrivateRecursive.async loadModule): Deleted.
(visibility.PrivateRecursive.linkAndEvaluateModule): Deleted.
(visibility.PrivateRecursive.async loadAndEvaluateModule): Deleted.
(visibility.PrivateRecursive.async requestImportModule): Deleted.
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h:
* Source/JavaScriptCore/jsc.cpp:
(dumpException):
(runWithOptions):
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
* Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::hostResolveImportedModule):
(JSC::AbstractModuleRecord::link):
* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
* Source/JavaScriptCore/runtime/Completion.cpp:
(JSC::createSymbolForEntryPointModule): Deleted.
(JSC::rejectPromise): Deleted.
(JSC::loadAndEvaluateModule): Deleted.
(JSC::loadModule): Deleted.
(JSC::linkAndEvaluateModule): Deleted.
* Source/JavaScriptCore/runtime/Completion.h:
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::finishCreation):
(JSC::createSymbolForEntryPointModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::loadModuleAndEvaluate):
(JSC::JSModuleLoader::fetchModule):
(JSC::JSModuleLoader::fetchModuleAndEvaluate):
(JSC::JSModuleLoader::evaluateModule):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSModuleLoader::provideFetch): Deleted.
(JSC::JSModuleLoader::loadAndEvaluateModule): Deleted.
(JSC::JSModuleLoader::linkAndEvaluateModule): Deleted.
* Source/JavaScriptCore/runtime/JSModuleLoader.h:
* Source/JavaScriptCore/runtime/SyntheticModuleRecord.cpp:
(JSC::SyntheticModuleRecord::link):
* Source/JavaScriptCore/runtime/SyntheticModuleRecord.h:
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.h:
* Source/WebCore/bindings/js/JSExecState.h:
(WebCore::JSExecState::loadModule):
(WebCore::JSExecState::loadModuleAndEvaluate):
(WebCore::JSExecState::fetchModule):
(WebCore::JSExecState::fetchModuleAndEvaluate):
(WebCore::JSExecState::evaluateModule):
(WebCore::JSExecState::linkAndEvaluateModule): Deleted.
* Source/WebCore/bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::evaluateModuleScriptInWorld):
(WebCore::ScriptController::evaluateModuleScript):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld): Deleted.
(WebCore::ScriptController::linkAndEvaluateModuleScript): Deleted.
* Source/WebCore/bindings/js/ScriptController.h:
* Source/WebCore/bindings/js/WorkerScriptFetcher.h:
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeModuleScript):
* Source/WebCore/workers/DedicatedWorkerThread.h:
(WebCore::DedicatedWorkerThread::workerObjectProxy const):
(WebCore::DedicatedWorkerThread::start): Deleted.
* Source/WebCore/workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::evaluateAndReportException):
(WebCore::WorkerOrWorkletScriptController::evaluate):
(WebCore::WorkerOrWorkletScriptController::loadModuleAndEvaluate):
(WebCore::WorkerOrWorkletScriptController::fetchWorkletModuleAndEvaluate):
(WebCore::jsValueToModuleKey): Deleted.
(WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously): Deleted.
(WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule): Deleted.
(WebCore::WorkerOrWorkletScriptController::loadAndEvaluateModule): Deleted.
* Source/WebCore/workers/WorkerOrWorkletScriptController.h:
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::workerOrWorkletThread):
* Source/WebCore/workers/WorkerOrWorkletThread.h:
(WebCore::WorkerOrWorkletThread::evaluateScriptIfNecessary):
* Source/WebCore/workers/WorkerThread.cpp:
(WebCore::WorkerThread::evaluateScriptIfNecessary):
* Source/WebCore/workers/WorkerThread.h:
* Source/WebCore/workers/shared/context/SharedWorkerContextManager.cpp:
(WebCore::SharedWorkerContextManager::registerSharedWorkerThread):
* Source/WebCore/worklets/WorkletGlobalScope.cpp:
(WebCore::WorkletGlobalScope::evaluate):
(WebCore::WorkletGlobalScope::fetchAndInvokeScript):

cf39202

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-09T03:27:00Z

EWS run on previous version of this PR (hash 7aabdfe)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch		✅ 🛠 jsc-armv7
	✅ 🛠 watch-sim		✅ 🧪 jsc-armv7-tests

TKDev7 · 2024-02-10T16:29:16Z

This is a horrible bug.

biozal · 2024-02-13T15:03:00Z

Is there a work around for this until this is fixed? This is causing a lot of issues for a product I'm working on and supporting Safari.

shvaikalesh · 2024-02-14T06:59:11Z

Is there a work around for this until this is fixed?

The fix proposed in this PR breaks the case of module importing itself. I don't see any other way except for re-implementing the module loader to adhere to the spec (https://tc39.es/ecma262/#cyclic-module-record), which will take some time.

biozal · 2024-02-14T15:09:52Z

Is there a work around for this until this is fixed?

The fix proposed in this PR breaks the case of module importing itself. I don't see any other way except for re-implementing the module loader to adhere to the spec (https://tc39.es/ecma262/#cyclic-module-record), which will take some time.

So what do we do then until this is fixed, tell people not to use Safari? I mean this is a pretty big problem for any modern web application.

mb21 · 2024-03-21T09:52:24Z

I don't see any other way except for re-implementing the module loader to adhere to the spec, which will take some time.

Would be great if this could be prioritized. A lot of people using modern frameworks like SvelteKit or Astro (that use native ESM modules) are running into this, and it's often very hard to debug, so they don't realize it's this bug.

shvaikalesh · 2024-03-24T05:12:01Z

Would be great if this could be prioritized. A lot of people using modern frameworks like sveltejs/kit#11601 or withastro/astro#10055 (that use native ESM modules) are running into this, and it's often very hard to debug, so they don't realize it's this bug.

Thank you for linking the issues, it's super important for our internal bookkeeping. Good news is that this issue being worked on, we are rewriting module loader to adhere to the spec, ETA is only a few weeks.

GauteHaugen · 2024-04-29T11:44:16Z

@shvaikalesh, Is there an update on this? Also, when this gets merged, what is the usual process/timeline for getting this fix out to end users?

webkit-early-warning-system · 2024-05-13T14:25:30Z

EWS run on previous version of this PR (hash aee0d36)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch		~~🛠 jsc-armv7~~
	✅ 🛠 watch-sim		~~🧪 jsc-armv7-tests~~

webkit-early-warning-system · 2024-05-13T23:52:19Z

EWS run on previous version of this PR (hash a0c5449)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch		✅ 🛠 jsc-armv7
	✅ 🛠 watch-sim		✅ 🧪 jsc-armv7-tests

webkit-early-warning-system · 2024-05-14T20:33:44Z

EWS run on previous version of this PR (hash 8c637db)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch		✅ 🛠 jsc-armv7
	~~🛠 watch-sim~~		✅ 🧪 jsc-armv7-tests

webkit-early-warning-system · 2024-05-14T21:33:16Z

EWS run on previous version of this PR (hash 3aacdb9)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🛠 watch~~		✅ 🛠 jsc-armv7
	~~🛠 watch-sim~~		~~🧪 jsc-armv7-tests~~

webkit-early-warning-system · 2024-10-09T23:04:03Z

EWS run on previous version of this PR (hash 7708e7d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2024-10-10T00:30:03Z

Safer C++ Build #909

❌ Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

⚠️ Found 1 fixed file! Please update expectations in Source/[WebKit/WebCore]/SaferCPPExpectations by running the following commands and update your pull request:

Tools/Scripts/update-safer-cpp-expectations -p WebCore --NoUncheckedPtrMemberChecker workers/service/context/ServiceWorkerDebuggable.h
Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncountedCallArgsChecker bindings/js/JSExecState.h

webkit-ews-buildbot · 2024-10-10T02:15:19Z

Safer C++ Build #936

❌ Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

⚠️ Found 1 fixed file! Please update expectations in Source/[WebKit/WebCore]/SaferCPPExpectations by running the following commands and update your pull request:

Tools/Scripts/update-safer-cpp-expectations -p WebCore --NoUncheckedPtrMemberChecker workers/service/context/ServiceWorkerDebuggable.h
Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncountedCallArgsChecker bindings/js/JSExecState.h

…ng a module containing a top-level await https://bugs.webkit.org/show_bug.cgi?id=242740 <rdar://problem/97370038> Reviewed by NOBODY (OOPS!). This change completely re-implements module loader to precisely follow the spec steps [1], resolving multiple issues revolving around importing modules with top-level `await`. Infinite retry of module fetching & parsing is removed as it's not part of the spec, nor other browsers behave in the same way. This patch also rewires the way module loader is hooked into workers / worklets, which became necessary due to functions like evaluateModule() became always `async`. Along with this, errors occuring in modules with top-level `await` are now properly reported to the console, resolving another developers' pain point. [1]: https://tc39.es/ecma262/#sec-cyclic-module-records * JSTests/test262/expectations.yaml: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/cors-crossorigin-requests-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-throw-importScripts.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-1-throw-importScripts.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/evaluation-order-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-3-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-fetch-error.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/error-type-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/error-type-3-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-1-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-3-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-4-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-1-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-3-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-4-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-5-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-6-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-7-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-error/worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-failure-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-parse-error-failure-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-parse-error-failure-expected.txt: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/builtins/BuiltinNames.h: * Source/JavaScriptCore/builtins/ModuleLoader.js: (visibility.PrivateRecursive.ensureModuleMapEntry): (visibility.PrivateRecursive.hostFetchAndLoadImportedModule): (visibility.PrivateRecursive.hostLoadImportedModule): (visibility.PrivateRecursive.fetchDescendantsOfAndLink): (visibility.PrivateRecursive.innerModuleLoading): (visibility.PrivateRecursive.moduleLinking): (visibility.PrivateRecursive.innerModuleLinking): (visibility.PrivateRecursive.moduleEvaluation): (visibility.PrivateRecursive.innerModuleEvaluation): (visibility.PrivateRecursive.async executeAsyncModule): (linkTimeConstant.gatherAvailableAncestors): (visibility.PrivateRecursive.asyncModuleExecutionFulfilled): (linkTimeConstant.asyncModuleExecutionRejected): (visibility.PrivateRecursive.fetchModule): (visibility.PrivateRecursive.fetchModuleAndEvaluate): (visibility.PrivateRecursive.evaluateModule): (visibility.PrivateRecursive.loadModule): (visibility.PrivateRecursive.loadModuleAndEvaluate): (visibility.PrivateRecursive.requestImportModule): (visibility.PrivateRecursive.dependencyKeysIfEvaluated): (linkTimeConstant.setStateToMax): Deleted. (linkTimeConstant.newRegistryEntry): Deleted. (visibility.PrivateRecursive.ensureRegistered): Deleted. (linkTimeConstant.forceFulfillPromise): Deleted. (linkTimeConstant.fulfillFetch): Deleted. (visibility.PrivateRecursive.requestFetch): Deleted. (linkTimeConstant.cacheSatisfy): Deleted. (async linkTimeConstant.cacheSatisfyAndReturn): Deleted. (visibility.PrivateRecursive.requestSatisfy): Deleted. (visibility.PrivateRecursive.requestSatisfyUtil): Deleted. (visibility.PrivateRecursive.link): Deleted. (visibility.PrivateRecursive.async asyncModuleEvaluation): Deleted. (visibility.PrivateRecursive.provideFetch): Deleted. (visibility.PrivateRecursive.async loadModule): Deleted. (visibility.PrivateRecursive.linkAndEvaluateModule): Deleted. (visibility.PrivateRecursive.async loadAndEvaluateModule): Deleted. (visibility.PrivateRecursive.async requestImportModule): Deleted. * Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp: (JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry): * Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h: * Source/JavaScriptCore/jsc.cpp: (dumpException): (runWithOptions): * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser<LexerType>::parseInner): * Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp: (JSC::AbstractModuleRecord::hostResolveImportedModule): (JSC::AbstractModuleRecord::link): * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::finishCreation): * Source/JavaScriptCore/runtime/Completion.cpp: (JSC::createSymbolForEntryPointModule): Deleted. (JSC::rejectPromise): Deleted. (JSC::loadAndEvaluateModule): Deleted. (JSC::loadModule): Deleted. (JSC::linkAndEvaluateModule): Deleted. * Source/JavaScriptCore/runtime/Completion.h: * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/JSModuleLoader.cpp: (JSC::JSModuleLoader::finishCreation): (JSC::createSymbolForEntryPointModule): (JSC::JSModuleLoader::loadModule): (JSC::JSModuleLoader::loadModuleAndEvaluate): (JSC::JSModuleLoader::fetchModule): (JSC::JSModuleLoader::fetchModuleAndEvaluate): (JSC::JSModuleLoader::evaluateModule): (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSModuleLoader::provideFetch): Deleted. (JSC::JSModuleLoader::loadAndEvaluateModule): Deleted. (JSC::JSModuleLoader::linkAndEvaluateModule): Deleted. * Source/JavaScriptCore/runtime/JSModuleLoader.h: * Source/JavaScriptCore/runtime/SyntheticModuleRecord.cpp: (JSC::SyntheticModuleRecord::link): * Source/JavaScriptCore/runtime/SyntheticModuleRecord.h: * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::link): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.h: * Source/WebCore/bindings/js/JSExecState.h: (WebCore::JSExecState::loadModule): (WebCore::JSExecState::loadModuleAndEvaluate): (WebCore::JSExecState::fetchModule): (WebCore::JSExecState::fetchModuleAndEvaluate): (WebCore::JSExecState::evaluateModule): (WebCore::JSExecState::linkAndEvaluateModule): Deleted. * Source/WebCore/bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): * Source/WebCore/bindings/js/ScriptController.cpp: (WebCore::ScriptController::loadModuleScriptInWorld): (WebCore::ScriptController::evaluateModuleScriptInWorld): (WebCore::ScriptController::evaluateModuleScript): (WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld): Deleted. (WebCore::ScriptController::linkAndEvaluateModuleScript): Deleted. * Source/WebCore/bindings/js/ScriptController.h: * Source/WebCore/bindings/js/WorkerScriptFetcher.h: * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::executeModuleScript): * Source/WebCore/workers/DedicatedWorkerThread.h: (WebCore::DedicatedWorkerThread::workerObjectProxy const): (WebCore::DedicatedWorkerThread::start): Deleted. * Source/WebCore/workers/WorkerOrWorkletScriptController.cpp: (WebCore::WorkerOrWorkletScriptController::evaluateAndReportException): (WebCore::WorkerOrWorkletScriptController::evaluate): (WebCore::WorkerOrWorkletScriptController::loadModuleAndEvaluate): (WebCore::WorkerOrWorkletScriptController::fetchWorkletModuleAndEvaluate): (WebCore::jsValueToModuleKey): Deleted. (WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously): Deleted. (WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule): Deleted. (WebCore::WorkerOrWorkletScriptController::loadAndEvaluateModule): Deleted. * Source/WebCore/workers/WorkerOrWorkletScriptController.h: * Source/WebCore/workers/WorkerOrWorkletThread.cpp: (WebCore::WorkerOrWorkletThread::workerOrWorkletThread): * Source/WebCore/workers/WorkerOrWorkletThread.h: (WebCore::WorkerOrWorkletThread::evaluateScriptIfNecessary): * Source/WebCore/workers/WorkerThread.cpp: (WebCore::WorkerThread::evaluateScriptIfNecessary): * Source/WebCore/workers/WorkerThread.h: * Source/WebCore/workers/shared/context/SharedWorkerContextManager.cpp: (WebCore::SharedWorkerContextManager::registerSharedWorkerThread): * Source/WebCore/worklets/WorkletGlobalScope.cpp: (WebCore::WorkletGlobalScope::evaluate): (WebCore::WorkletGlobalScope::fetchAndInvokeScript):

webkit-early-warning-system · 2024-10-10T02:35:51Z

EWS run on current version of this PR (hash cf39202)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2024-10-10T06:41:13Z

Safer C++ Build #988

❌ Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

⚠️ Found 1 fixed file! Please update expectations in Source/[WebKit/WebCore]/SaferCPPExpectations by running the following commands and update your pull request:

Tools/Scripts/update-safer-cpp-expectations -p WebCore --NoUncheckedPtrMemberChecker workers/service/context/ServiceWorkerDebuggable.h
Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncountedCallArgsChecker bindings/js/JSExecState.h

kalegd · 2024-10-31T20:27:59Z

Just expressing additional interest in seeing these changes go through as it's not uncommon to run into this issue. Thanks for the hard work

ilyakamens · 2024-11-01T00:45:02Z

Just expressing additional interest in seeing these changes go through as it's not uncommon to run into this issue. Thanks for the hard work

Ditto!

qiyundai · 2024-12-02T15:19:53Z

Just expressing additional interest in seeing these changes go through as it's not uncommon to run into this issue. Thanks for the hard work

Ditto!

Ditto

MenloDorian · 2025-02-27T21:07:27Z

This PR requires significant feature-level work to complete. We don't currently have anyone working on it, but we hear the requests and will consider it in our planning. Thanks.

darinadler · 2025-03-03T21:49:15Z

I’m so glad someone took a crack at this, but it seems like we need quite a bit more work to complete it.

wmertens · 2025-08-02T11:15:22Z

is there any workaround possible, for example retrying a failed import? Any application that wants to have client code blocked until environment-specific code ran will encounter this, right?

aralroca · 2025-09-19T15:18:12Z

I hope this will be merged soon

nt1m · 2026-02-14T03:19:26Z

There's an on-going rewrite that will fix this issue: #57827

shvaikalesh requested a review from a team as a code owner February 9, 2024 03:26

shvaikalesh self-assigned this Feb 9, 2024

shvaikalesh added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 9, 2024

shvaikalesh marked this pull request as draft February 9, 2024 03:42

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from 7aabdfe to aee0d36 Compare May 13, 2024 14:25

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2024

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label May 13, 2024

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from aee0d36 to a0c5449 Compare May 13, 2024 23:51

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 14, 2024

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label May 14, 2024

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from a0c5449 to 8c637db Compare May 14, 2024 20:33

shvaikalesh marked this pull request as ready for review May 14, 2024 20:44

shvaikalesh requested review from cdumez and rniwa as code owners May 14, 2024 20:44

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 14, 2024

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label May 14, 2024

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from 8c637db to 3aacdb9 Compare May 14, 2024 21:33

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from 3aacdb9 to 7f9c271 Compare May 14, 2024 21:51

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from 8541e4f to 7708e7d Compare October 9, 2024 23:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

shvaikalesh force-pushed the eng/JSC-ReferenceError-when-multiple-modules-are-simultaneously-importing-a-module-containing-a-top-level-await branch from 7708e7d to cf39202 Compare October 10, 2024 02:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

caugner mentioned this pull request Apr 14, 2025

Safari only partially supports top-level await mdn/browser-compat-data#26510

Merged

ddbeck mentioned this pull request May 12, 2025

Reconsideration: allow top-level await status regression web-platform-dx/web-features#2957

Closed

Jarred-Sumner mentioned this pull request Jun 3, 2025

When using concurrent import(...) and top-level await, Bun throws ReferenceError, Node does not oven-sh/bun#20159

Closed

This was referenced Aug 26, 2025

Separate load functions: reactive vs static wuchalejs/wuchale#89

Merged

Optionally support separate loader for SSR wuchalejs/wuchale#91

Merged

mb21 mentioned this pull request Sep 20, 2025

ESM Module Loading: Cyclic Module Records / multiple top-level awaits in different modules web-platform-tests/interop#1105

Closed

lishaduck mentioned this pull request Nov 26, 2025

Broken In Safari PetalNet/notes#2

Open

fruitriin mentioned this pull request Nov 27, 2025

開発環境にSafariでログインしただけで出る最後の警告/エラーを解決または調査したい misskey-dev/misskey#16875

Open

1 task

K1DV5 mentioned this pull request Jan 1, 2026

_w_runtime_ is not defined wuchalejs/wuchale#227

Closed

nt1m closed this Feb 14, 2026

github-actions Bot mentioned this pull request May 5, 2026

Fix TLA sibling import running before shared dep settles (#30259) oven-sh/bun#30262

Merged

Conversation

shvaikalesh commented Feb 9, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cf39202

Uh oh!

webkit-early-warning-system commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TKDev7 commented Feb 10, 2024

Uh oh!

biozal commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shvaikalesh commented Feb 14, 2024

Uh oh!

biozal commented Feb 14, 2024

Uh oh!

mb21 commented Mar 21, 2024

Uh oh!

shvaikalesh commented Mar 24, 2024

Uh oh!

GauteHaugen commented Apr 29, 2024

Uh oh!

webkit-early-warning-system commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Oct 10, 2024

Safer C++ Build #909

Uh oh!

webkit-ews-buildbot commented Oct 10, 2024

Safer C++ Build #936

Uh oh!

webkit-early-warning-system commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Oct 10, 2024

Safer C++ Build #988

Uh oh!

kalegd commented Oct 31, 2024

Uh oh!

ilyakamens commented Nov 1, 2024

Uh oh!

qiyundai commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MenloDorian commented Feb 27, 2025

Uh oh!

darinadler commented Mar 3, 2025

Uh oh!

wmertens commented Aug 2, 2025

Uh oh!

aralroca commented Sep 19, 2025

Uh oh!

nt1m commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

shvaikalesh commented Feb 9, 2024 •

edited by webkit-early-warning-system

Loading

`cf39202`

webkit-early-warning-system commented Feb 9, 2024 •

edited

Loading

biozal commented Feb 13, 2024 •

edited

Loading

webkit-early-warning-system commented May 13, 2024 •

edited

Loading

webkit-early-warning-system commented May 13, 2024 •

edited

Loading

webkit-early-warning-system commented May 14, 2024 •

edited

Loading

webkit-early-warning-system commented May 14, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 9, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading

qiyundai commented Dec 2, 2024 •

edited

Loading