Improve efficiency of if statements

credod · credod · commit 42b1154bf1a7 · 2026-02-12T14:24:50.000-06:00
diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp
@@ -952,11 +952,9 @@ void HTMLMediaElement::didMoveToNewDocument(Document& oldDocument, Document& new
     ASSERT_WITH_SECURITY_IMPLICATION(&document() == &newDocument);
 
     // Handle lazy loading observer transfer between documents
-    if (newDocument.settings().lazyMediaLoadingEnabled()) {
-        oldDocument.lazyLoadMediaObserver().unobserve(*this, oldDocument);
-        if (isLazyLoadable())
-            LazyLoadMediaObserver::observe(*this);
-    }
+    oldDocument.lazyLoadMediaObserver().unobserve(*this, oldDocument);
+    if (newDocument.settings().lazyMediaLoadingEnabled() && isLazyLoadable())
+        LazyLoadMediaObserver::observe(*this);
 
     if (m_shouldDelayLoadEvent) {
         oldDocument.decrementLoadEventDelayCount();
@@ -1037,7 +1035,7 @@ void HTMLMediaElement::attributeChanged(const QualifiedName& name, const AtomStr
         // If a src attribute of a media element is set or changed, the user
         // agent must invoke the media element's media element load algorithm.
         if (!newValue.isNull()) {
-            if (isLazyLoadable() && document().settings().lazyMediaLoadingEnabled() && m_networkState == NETWORK_EMPTY)
+            if (m_networkState == NETWORK_EMPTY && document().settings().lazyMediaLoadingEnabled() && isLazyLoadable())
                 LazyLoadMediaObserver::observe(*this);
             else
                 prepareForLoad();
@@ -1142,7 +1140,7 @@ void HTMLMediaElement::didFinishInsertingNode()
 
     if (m_inActiveDocument && m_networkState == NETWORK_EMPTY) {
         if (!attributeWithoutSynchronization(srcAttr).isEmpty()) {
-            if (isLazyLoadable() && document().settings().lazyMediaLoadingEnabled())
+            if (document().settings().lazyMediaLoadingEnabled() && isLazyLoadable())
                 LazyLoadMediaObserver::observe(*this);
             else
                 prepareForLoad();
@@ -1538,7 +1536,7 @@ bool HTMLMediaElement::hasLazyLoadableAttributeValue(StringView attributeValue)
 
 bool HTMLMediaElement::isLazyLoadable() const
 {
-    if (!document().frame() || !document().frame()->checkedScript()->canExecuteScripts(ReasonForCallingCanExecuteScripts::NotAboutToExecuteScript))
+    if (!document().frame() || !protect(document().frame()->script())->canExecuteScripts(ReasonForCallingCanExecuteScripts::NotAboutToExecuteScript))
         return false;
 
     if (document().paginated())
@@ -5900,7 +5898,7 @@ void HTMLMediaElement::sourceWasAdded(HTMLSourceElement& source)
     // the media element's resource selection algorithm.
     if (m_networkState == NETWORK_EMPTY) {
         m_nextChildNodeToConsider = source;
-        if (isLazyLoadable() && document().settings().lazyMediaLoadingEnabled()) {
+        if (document().settings().lazyMediaLoadingEnabled() && isLazyLoadable()) {
             LazyLoadMediaObserver::observe(*this);
             return;
         }
